Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[81300] Update VSOReloader to correctly upsert organization data #16470

Merged

Conversation

jvcAdHoc
Copy link
Contributor

@jvcAdHoc jvcAdHoc commented Apr 23, 2024

Summary

  • This pr fixes a bug with the VSOReloader that prevented organization data from updating

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Old behavior was that the organization attributes did not update
  • tested Veteran::Service::Organization.import(vso_orgs, on_duplicate_key_update: %i[name phone state]) vs Veteran::Service::Organization.import(vso_orgs, on_duplicate_key_ignore: true) in the rails console to confirm old behavior and intended behavior

What areas of the site does it impact?

This will impact the active POA widget and anything that reads organization name, phone, and state

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@jvcAdHoc jvcAdHoc added the representative-status-widget Benefits Representation Management product label label Apr 23, 2024
@jvcAdHoc jvcAdHoc self-assigned this Apr 23, 2024
@jvcAdHoc jvcAdHoc requested review from a team April 23, 2024 19:52
@jvcAdHoc jvcAdHoc marked this pull request as ready for review April 23, 2024 19:53
@jvcAdHoc jvcAdHoc requested review from a team as code owners April 23, 2024 19:53
@jvcAdHoc jvcAdHoc changed the title update vsoreloader to correctly upsert organization data [81300] Update VSOReloader to correctly upsert organization data Apr 23, 2024
Comment on lines +64 to +66
expect(org.name).to eq('African American PTSD Association')
expect(org.phone).to eq('253-589-0766')
expect(org.state).to eq('WA')
Copy link
Contributor Author

@jvcAdHoc jvcAdHoc Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these values come from the cassette

Copy link
Contributor

@nihil2501 nihil2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vfs-bot va-vfs-bot temporarily deployed to 81300-dav-information-in-staging-does-not-match-trexler-file/main/main April 23, 2024 20:42 Inactive
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@cosu419 cosu419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved

@jvcAdHoc jvcAdHoc merged commit 56b7d41 into master Apr 25, 2024
33 checks passed
@jvcAdHoc jvcAdHoc deleted the 81300-dav-information-in-staging-does-not-match-trexler-file branch April 25, 2024 15:27
Copy link
Contributor

@gabezurita gabezurita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

gabezurita added a commit that referenced this pull request Apr 25, 2024
* master:
  creates data to seed dev & staging (#16502)
  post database updates (#16500)
  Added auth-only feature flipper for 10-10EZR (#16496)
  update vsoreloader to correctly upsert organization data (#16470)
  database updates (#16475)
  Bump super_diff from 0.11.0 to 0.12.0 (#16495)
gabezurita added a commit that referenced this pull request Apr 25, 2024
…-OGC-number

* arf.80297/ARP-OGC-number-migrations:
  creates data to seed dev & staging (#16502)
  post database updates (#16500)
  Added auth-only feature flipper for 10-10EZR (#16496)
  update vsoreloader to correctly upsert organization data (#16470)
  database updates (#16475)
  Bump super_diff from 0.11.0 to 0.12.0 (#16495)
  arf-80297 add ARP verified_representative migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
representative-status-widget Benefits Representation Management product label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants