-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[81300] Update VSOReloader to correctly upsert organization data #16470
[81300] Update VSOReloader to correctly upsert organization data #16470
Conversation
expect(org.name).to eq('African American PTSD Association') | ||
expect(org.phone).to eq('253-589-0766') | ||
expect(org.state).to eq('WA') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these values come from the cassette
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
955eef2
to
e5eafba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
…-OGC-number * arf.80297/ARP-OGC-number-migrations: creates data to seed dev & staging (#16502) post database updates (#16500) Added auth-only feature flipper for 10-10EZR (#16496) update vsoreloader to correctly upsert organization data (#16470) database updates (#16475) Bump super_diff from 0.11.0 to 0.12.0 (#16495) arf-80297 add ARP verified_representative migration
Summary
Related issue(s)
Testing done
Veteran::Service::Organization.import(vso_orgs, on_duplicate_key_update: %i[name phone state])
vsVeteran::Service::Organization.import(vso_orgs, on_duplicate_key_ignore: true)
in the rails console to confirm old behavior and intended behaviorWhat areas of the site does it impact?
This will impact the active POA widget and anything that reads organization name, phone, and state
Acceptance criteria